Skip to content

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Feb 1, 2022

We've come across a few cases where CG fails due to environment issues (missing .NET).
Continue on error as this is non-critical functionality.

To double check:

We've come across a few cases where CG fails due to environment issues (missing .NET).
Continue on error as this is non-critical functionality.
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would mean we don't have to set disableComponentGovernance: true in jobs where we expect the task to fail. However, I'm a bit concerned this will hide problems and mean the task remains enabled despite no chance of success. That seems wasteful.

(We only knew about the newly enabled task here when @captainsafia saw our internal build breaks on Linux MUSL.)

@dougbu
Copy link
Contributor

dougbu commented Feb 1, 2022

Separately, we chatted about the new CG scan this morning and @wtgodbe took an action item about doing the opposite: Ensuring builds of release branches fail when high or critical CG bugs are detected. Is that possible❔

@mmitche
Copy link
Member Author

mmitche commented Feb 1, 2022

Separately, we chatted about the new CG scan this morning and @wtgodbe took an action item about doing the opposite: Ensuring builds of release branches fail when high or critical CG bugs are detected. Is that possible❔

Not that I know of. They will surface in S360

@mmitche
Copy link
Member Author

mmitche commented Feb 1, 2022

This would mean we don't have to set disableComponentGovernance: true in jobs where we expect the task to fail. However, I'm a bit concerned this will hide problems and mean the task remains enabled despite no chance of success. That seems wasteful.

(We only knew about the newly enabled task here when @captainsafia saw our internal build breaks on Linux MUSL.)

I believe the automatic CG detection has been continueOnError forever. The task we are injecting and the auto-injected task are the same.

@mmitche mmitche merged commit 57e47a3 into dotnet:main Feb 1, 2022
@mmitche mmitche deleted the cg-coe branch February 9, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants